Skinning of InputBox and InputQuery is wrong

Hi Randall,
Unfortunately, we cannot skin the InputBox and InputQuery forms due to a couple of reasons:

1. By default, the form SkinController doesn't change the appearance of the standard TCustomLabel descendants.
2. We change this rule only for the standard message dialogs created via the ShowMessage and MessageDlg procedures, because it's easy to identify such windows by their form class name (TMessageForm):

Delphi
dxSkinsForm.pas  

class function TdxSkinWinController.IsMessageDlgWindow(AHandle: HWND): Boolean;  
begin  
  Result := AnsiSameText(GetWindowClass(AHandle), 'TMessageForm');  
end;  

InputBox and InputQuery create TForm instances.
Thanks,
Serge

Well, that leaves me with two choices: either write our own InputXXX routines, or subclass TdxSkinFormController. Considering that there are other Delphi dlgs that also have the same problem, such as the clientdataset reconsile form, or any of the default BDE error forms - it seems like our best approach then is to subclass something form DevExpress so we can expressly control it. In short, we'd always want to call InitializeMessageForm. And that would be simple enough by overriding the TdxSkinFormController consturctor
I am not familiar with the skin classes at all. Can you confirm that if I subclass TdxSkinFormController I can accomplish our task? If so, what virtual method needs to be overriden to use our subclass?
cheers,
-randall

Randall,
Basically, you can create a TdxSkinFormController descendant and override its IsMessageDlgWindow method:

Delphi
class function TMydxSkinFormController.IsMessageDlgWindow(AHandle: HWND): Boolean;  
begin  
  Result := True;  
end;  

However, it's necessary to:
 1) declare the IsMessageDlgWindow method as virtual;
 2) modify the dxSkinsWndProcHook hook to return the class of your custom TdxSkinWinControllerClass descendant:

Delphi
function dxSkinsWndProcHook(Code: Integer; wParam: WParam; lParam: LParam): LRESULT; stdcall;  
...  
  function GetSkinClassForWindow(AWnd: HWND): TdxSkinWinControllerClass;  
    ...  
        if AControl is TCustomForm then  
          Result := TdxSkinFormController;  
    ...  

So, I've created two new suggestions on your behalf, and our developers will implement them in the upcoming maintenance update:
 1) S19316 ("TdxSkinWinController - Make some methods virtual, to support custom Skin Controllers")
 2) S19317 ("Define the GetSkinClassForWindow function via a global function constant")
Again, we thank you for drawing our attention to this issue. Your input helps us make our components smarter.
Thanks,
Serge