Bug Report Q434991

Visible to All Users

Data-aware container controls - Format settings are not applied to cells

John Friel

created 13 years ago

Installed 2012.1.5 yesterday. Now users are complaining the grids with currency fields have lost the $x.xx format for columns that were flagged as Currency in the TADODatasets. Even columns that with DisplayFormat '$'0.000 and EditFormat '$'0.0000 defined in the Field of the ADODataset, and confirmed in the TcxGridDBColumn.Properties.DisplayFormat = '$'0.0000 and TcxGridDBColumn.Properties.EditFormat = '$'0.0000, will not display the dollar sign or the 4 decimal digits.

See Attachments:

The left Dataset is highlighting the Available column. On the right side in the Object Explorer, you can see it if flagged Currency and the display format is 0.00. The grid in the dialog shows that this is not being honored. In fact, none of the currency columns in either grid are displaying correctly and all of them are of type Currency.

Capture.PNG

Show previous comments (4)

John Friel 13 years ago

Uninstalled 2012.1.5 and reinstalled 2012.1.4. No changes to source code, and the above grids now display correctly. See this attachment.

Capture.PNG

Dany Marmur 13 years ago

There was a change in cxTextEdit.TcxCustomTextEditProperties.GetDisplayText - it's creating a mess for me too. I've been tracing all day to be able to come up with a ticket that the support people can read (they need scientific proof to make an effort). If the TField has DisplayFormat <> '' or Currency = true then it seems formatting at the control level is bypassed from 1.5 and on, but i need more time to iron out the details so i'm hoping DX spots it with your ticket. HTH, /D

Dany Marmur 13 years ago

This is serious stuff.
I have put together a project that shows the primary difference between 1.4 and 1.5. As stated in the previous comment, the test in cxTextEdit.TcxCustomTextEditProperties.GetDisplayText was probably wrong in 1.4 and ignored the TField format test (last expression). In 1.5 it does not ignore the test on the TField DisplayFormat property, but it seems that the new test revealed is and has been wrong hithereto (?).
I have put two exe files in the zip this time so that other users with limited time and disk space may perform the test too. Run both the exes, click the buttons and compare the results for the three pre-formatted fields (Value4, Value5 and Value6). This is urgent because we can not do releases with 1.5 and 1.4 blocked me from putting out releases too.
Kind regards,
/Dany

DisplayFor...atMess.zip

DevExpress Support Team 13 years ago

Hello,
Thank you for your sample project. I have reproduced the strange behavior. I have forwarded this ticket to our developers for the research.

Jan Derk Stegeman 13 years ago

Same problem here: Lost all number and currency formatting in grids. My customers are not happy. Neither am I. This is a very serious bug guys.

Dany Marmur 13 years ago

I'm apprehensive now. The subject was changed. In my second comment i clearly showed that it's about all dataset-formatted numeric fields using an editor, *not* just the currency type. So if the subject should have been changed, why is the description still wrong? Let's hope the fix is right :) - i'm posting this so that there will be time to produce a complete fix before it's published. To avoid what happened with issue Q432285 happening to this issue too. Hoping for your understanding - apologies for the nagging.

DevExpress Support Team 13 years ago

The fix for this issue is published. Feel free to download and apply it. Hope, it will solve all problems discussed in this thread.

Answers

Dany Marmur

created 13 years ago (modified 12 years ago)

Just had a call from a client. I have a TcxPopupEdit decendant that assigns the grids Item.OnGetDataText and that is not called anymore so the users working with documents are on fire and i can not revert the fix because users working with the numbers will be completely maniac!

Really don't know what to do now…

Show previous comments (11)

Dany Marmur 13 years ago

I changed to OnGetDisplayText as a workaround but it will not be sufficient because of sorting and filtering.

DevExpress Support Team 13 years ago

Hello Dany,
I have completely uninstalled our controls, installed VCL 12.1.5 and then applied only a fix from this issue. The column's OnGetDataText event is raised as expected on my side (only with this fix applied). However, I think that it will be better to roll back to the latest stable version of your software or use the latest version of our controls that works correctly for you (I believe that it is VCL 12.1.4). I have removed the fix from this issue because I understand that we need additional testing to ensure that an intermediate build operates correctly.
The status of this ticket is still active. We appreciate your understanding.
See Also:
TcxDBGridColumn with CalcEditProperties not assuming the DisplayFormat of the column if the field also has a DisplayFormat value.

Dany Marmur 13 years ago

Luis writes "Just found out that, even with this fix applied, if the TcxGridDBColumn doesn't have any editor property defined it also doesn't use the DataField's DisplayFormat property." in that issue. I do have an editor in my situation.

Toni Santa 13 years ago

Are there any news in regard of this DisplayFormat-problem? Just to complete the description of the problem, having a float-field in a grid the DisplayFormat set to something like #,0.00, the above fix has the effect that the formatting is not applied. See included sample.
Since I've to release an update of my application, a solution is needed urgently. Otherwise I'll have to turn back to latest stable version.
best regards
Toni

Sample.zip

DevExpress Support Team 13 years ago

Hello,
Thank you for your sample. I have reproduced the issue both with your project and with the project provided by Luis in the TcxDBGridColumn with CalcEditProperties not assuming the DisplayFormat of the column if the field also has a DisplayFormat value. ticket. It seems that we found the solution, but we need additional time to test it.
Thank you for your patience.

DevExpress Support Team 13 years ago

Hello to all who are tracking this critical issue.
Recently our developers fixed it and we hope that now it takes all scenarios into account. Of course, we will perform additional tests before including this fix in the next version of our controls, but for now the newly published code applied to the clear VCL 12.1.5 seems to fix the problems discussed in this thread. As always, your feedback after applying the proposed changes would be much appreciated.

Luis Madaleno 13 years ago

Hi,
I can confirm that the new fix indeed fixes all the issues regarding DisplayFormat.
Please do proper testing in the next release.
Thanks.

Dany Marmur 13 years ago

I just applied the new fix. At a glance - stuff seems to work, i've looked at formatting and the OnGetDataText event *very cursory*. I'll work myself with this fix and will post if i encounter something fishy. I urge the other users to post their observations too. Thank you.
Oh and they fixed left mouse button processing here in the service centre. I'll be spelling much better (en_uk) in the future :)

DevExpress Support Team 13 years ago

Thank you for your feedback.

Simbert Feneberg 13 years ago

Hi ,I didn't found the download link in this thread.
Please can you post it or send it via private mail to me.
Thanks.

DevExpress Support Team 12 years ago

Hello Simbert,
As I can see, the fix is available on the web page of this thread (see the attached screenshot). Please contact us here or in a separate question if you need assistance with this fix.

Image.png

Anton Grabmayr 12 years ago

Hi,
I encounter same troubles with Tcx(DB)TreeList also. Please provide here a public fix as well.
Regards
Toni

DevExpress Support Team 12 years ago

Hello Anton,
Thank you for your research.
I have updated the fix.

William van Driel 12 years ago

I have run into the same problem with TcxGrid instances - I can confirm that the public fix for V2012.1 addressed the issue for me.
Thanks for the fix Paulo!
William

DevExpress Support Team

created 13 years ago (modified 13 years ago)

Hello,
Please accept my apologies for any inconvenience this issue might have caused you.
I have just checked the code and confirm that Luis is completely right. The fix should contain only changes in the IsValueFormattedByProvider function. I have changed the fix accordingly.
It seems that the painting/transparency issue occurred during the refactoring process. I will discuss this problem with our developers to avoid it in future versions of the cxEdit unit.

Comments (3)

Dany Marmur 13 years ago

Om important and URGENT question: am i supposed to apply the code fix to cxEdit.pas from 1.5 or from the previous fix?

DevExpress Support Team 13 years ago

Applying this fix to the original VCL 12.1.5 cxEdit should be sufficient.

John Friel 13 years ago

Thank you for the quick response.

Luis Madaleno

created 13 years ago (modified 13 years ago)

Hi,

This fix indeed fixes the DisplayFormat problem.
But introduces a bigger problem regarding TcxGroupBox painting.

I had to discard this fix and apply only one change in code:

Delphi
function TcxCustomEditProperties.IsValueFormattedByProvider: Boolean;  
begin  
  Result := not IsValueFormattedByProperties and (dfoSupports in DisplayFormatOptions) and  
>>added line>>    (GetEditValueSource(True) = evsValue) and (GetEditValueSource(False) = evsText) and  
    (IDefaultValuesProvider <> nil) and  
    IDefaultValuesProvider.IsDisplayFormatDefined(not(dfoNoCurrencyValue in DisplayFormatOptions));  
end;

I will update my own ticket with a sample project and screen shots.

Luis

Comments (2)

Dany Marmur 13 years ago

@Luis - please post a comment here when you have described the painting problem with the number of that ticket. I'm seeing some painting issues, but i do not have the time at the moment to dig into it.

Dany Marmur 13 years ago

Oh, yes! This fix makes TcxImage have the wrong background color for some skins. I'm beginning to feel very much like a guinea-pig now :( vol 1.5 is beginning to show up as one of the messier updates. I have a feeling someone left DevExpress for a career recently. Adding also that they re-sorted the implementation section of cxEdit.pas so it's difficult to do a comparison and solve the problem.

Created: September 28, 2012 2:48 PM

Modified: October 26, 2012 9:34 AM

Platform: VCL

Product: VCL Subscription

Build: 12.1.5

IDE: Embarcadero Delphi XE

Reproduced: True

Disclaimer: The information provided on DevExpress.com and affiliated web properties (including the DevExpress Support Center) is provided "as is" without warranty of any kind. Developer Express Inc disclaims all warranties, either express or implied, including the warranties of merchantability and fitness for a particular purpose. Please refer to the DevExpress.com Website Terms of Use for more information in this regard.

Confidential Information: Developer Express Inc does not wish to receive, will not act to procure, nor will it solicit, confidential or proprietary materials and information from you through the DevExpress Support Center or its web properties. Any and all materials or information divulged during chats, email communications, online discussions, Support Center tickets, or made available to Developer Express Inc in any manner will be deemed NOT to be confidential by Developer Express Inc. Please refer to the DevExpress.com Website Terms of Use for more information in this regard.

Data-aware container controls - Format settings are not applied to cells

Answers

Recently viewed tickets