BuyLog In
Bug Report T313185
Visible to All Users

Potential issues in the KeyboardFocusHelper class implementation

created 9 years ago

[DevExpress Support Team: CLONED FROM T313092: Keyboard Focus is broken when selecting panels]
Take a close look at KeyboardFocusHelper.cs. In GetElementToFocus(), on 1 line, there is "if (element is IInputElement)", and then right after the if, there is "if (element is FrameworkElement)". Well, the second if will never run because a FrameworkElement is a IInputElement. So what is the second if for? The same quirky 2 if statements can also be found in CanFocusResultCallback(). A UIElement is a IInputElement. So either the first if is redundant, or the second one.

Also, testing for Focusable is not enough, you should include IsEnabled. See the method FocusHelper.CanBeFocused(), which does it right. That way, focus will go to an element that can actually receive focus. Although if nothing is enabled, the first focusable should be chosen.

Comments (1)
DevExpress Support Team 9 years ago

    Thank you for your observation, Paul. I have passed this thread to our R&D team so they thoroughly analyze the KeyboardFocusHelper class implementation in view of your remarks.

    Thanks,
    Michael

    Sign in to comment on this post

    Answers approved by DevExpress Support

    created 9 years ago

    We have fixed the issue described in this ticket and will include the fix in our next maintenance update. To apply this solution before the official update, request a hotfix by clicking the corresponding link for product versions you require.

    Note: Hotfixes may be unavailable for beta versions and updates that are about to be released.

      Sign in to comment on this post

      Disclaimer: The information provided on DevExpress.com and affiliated web properties (including the DevExpress Support Center) is provided "as is" without warranty of any kind. Developer Express Inc disclaims all warranties, either express or implied, including the warranties of merchantability and fitness for a particular purpose. Please refer to the DevExpress.com Website Terms of Use for more information in this regard.

      Confidential Information: Developer Express Inc does not wish to receive, will not act to procure, nor will it solicit, confidential or proprietary materials and information from you through the DevExpress Support Center or its web properties. Any and all materials or information divulged during chats, email communications, online discussions, Support Center tickets, or made available to Developer Express Inc in any manner will be deemed NOT to be confidential by Developer Express Inc. Please refer to the DevExpress.com Website Terms of Use for more information in this regard.